Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for the GPU metrics #147

Closed
amete opened this issue Jul 2, 2020 · 3 comments
Closed

Add unit tests for the GPU metrics #147

amete opened this issue Jul 2, 2020 · 3 comments
Labels
enhancement New feature or request tests Issues to do with tests
Milestone

Comments

@amete
Copy link
Collaborator

amete commented Jul 2, 2020

This can be optional but we should eventually add unit tests for the GPU metrics. Currently we have no coverage on that front. Now, this is a bit more involved I suppose because we possibly need to add a bit of cuda code and make our cmake setup smarter to be able to build it via nvcc etc. This is definitely not a showstopper but would be good to address sooner than later.

@amete amete added the enhancement New feature or request label Jul 2, 2020
@graeme-a-stewart
Copy link
Member

Yep, we should do this and at least check that we get some metrics back from GPUs, so it will require some extra codes in CMake to do this (fortunately, NVIDIA GPUs are well supported in CMake, but it may bump the minimum version).

@graeme-a-stewart graeme-a-stewart added this to the v2.2 milestone Sep 8, 2020
@graeme-a-stewart graeme-a-stewart modified the milestones: v2.2, v2.3 Jan 27, 2021
@amete amete added the tests Issues to do with tests label Feb 5, 2021
@graeme-a-stewart
Copy link
Member

I wonder, could we say this is fixed with #195? It seems a very smart way to test the monitor without actually needing to depend on a graphics card itseld?

@graeme-a-stewart
Copy link
Member

We condsider closed by #195

@graeme-a-stewart graeme-a-stewart modified the milestones: v2.3, v3.0 Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tests Issues to do with tests
Projects
None yet
Development

No branches or pull requests

2 participants