Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/access control #288

Merged
merged 7 commits into from
Apr 3, 2020
Merged

Refactor/access control #288

merged 7 commits into from
Apr 3, 2020

Conversation

alcueca
Copy link
Contributor

@alcueca alcueca commented Apr 1, 2020

Now that OpenZeppelin's AccessControl.sol does everything we did with RBAC.sol and later Roles.sol, I've refactored our contracts to use OpenZeppelin's.

@alcueca alcueca requested a review from vibern0 April 1, 2020 20:58
@vibern0
Copy link
Member

vibern0 commented Apr 2, 2020

Smart move. Well done 👏
Looks good.
I see that the CI fails with test/access/Renounceable.test.ts(2,10): error TS2724: Module '"../../types/truffle-contracts"' has no exported member 'RenounceableMockInstance'. Did you mean 'RenounceableQueueInstance'?
Possibly, it did not fail locally because the files from the last compile still exist, and maybe, with luck, it deploys in the same address, so it did not crash on the tests. Just remove your build folder and you should see the same error 👍

Copy link
Member

@vibern0 vibern0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fix the import on tests. Thanks, man 🙏

@alcueca
Copy link
Contributor Author

alcueca commented Apr 2, 2020

Just forgot to remove the test files that were not needed anymore. Thanks!

@vibern0
Copy link
Member

vibern0 commented Apr 2, 2020

Cool.
I see the CI got crazy and failed in one step. Let's see if it works if run again.

Also, I've realized one interesting thing that I haven't seen before.
It is not urgent because this error happens in coverage, but it's something to look at. I'll open an issue with it.

@alcueca
Copy link
Contributor Author

alcueca commented Apr 2, 2020

Failed again :/

I saw that warning, thanks for opening the issue.

@vibern0 vibern0 merged commit 562e1c1 into master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants