Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different label colours #1

Open
TimRepke opened this issue Sep 28, 2017 · 2 comments
Open

Different label colours #1

TimRepke opened this issue Sep 28, 2017 · 2 comments

Comments

@TimRepke
Copy link
Member

At the moment, all denotations have the same colour. For better readability, the type should define the colour of that denotation.

@moodys28
Copy link

moodys28 commented Oct 1, 2017

moodys28

I would like to work on this.

@TimRepke
Copy link
Member Author

TimRepke commented Oct 2, 2017

@moodys28 cool! feel free to clone the repo and submit a pullrequest!
I haven't decided on the best approach to this issue yet, but would like something that requires the least amount of configuration when setting up an annotation task. Colours should be applied automatically and should be deterministic (always the same for the same label), so having a "hash function" that maps label to a hex colourcode would be perfect. After that is as simple as changing a few lines where the colour for a denotation element is set:
https://github.com/TimRepke/enno/blob/master/enno/src/js/Enno.js#L431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants