Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDA-20031 us realm date fields #15

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

benjaminflessner
Copy link
Collaborator

This started from https://jira.hl7.org/browse/CDA-20031, but I quickly discovered that almost every use of "US Realm Date and Time (either flavor) had invalid schematron. It either:

  • Didn't test anything (so the required existence of the field was not tested)
  • Incorrectly required @value to be longer than 8 (this is unnecessary, since every US Realm Date and Time already has its own check.

Part of the problem is that when you apply a US Realm Date and Time template onto an effectiveTime element, the auto-generated Trifolia export tries to require effectiveTime/templateId which doesn't exist; so each of these places needs custom schematron... and it was often done incorrectly.

Now this is caught in the following places:

  • US Realm Header:
    • effectiveTime (yes, this was never validated)
    • author/time (never validated for existence)
    • legalAuthenticator/time (never validated for existence)
  • Progress Note / Op Note:
    • documentationOf/serviceEvent/effectiveTime (removed @value requirement)
  • Progress Note / Consult Note / H&P Note:
    • componentOf/encompassingEncounter (removed @value requirement)

Copy link
Collaborator

@mjszczep mjszczep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants