From 8b5e6622a05bce97c4bef2f4c7a1e2a74f408dc3 Mon Sep 17 00:00:00 2001 From: Hyo-Kyung Lee Date: Wed, 25 Sep 2024 22:28:22 -0500 Subject: [PATCH 1/2] Improve grammar and style of comment block in bin/genparser --- bin/genparser | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/bin/genparser b/bin/genparser index 619dbfaa3ed..795ca8cd6a4 100755 --- a/bin/genparser +++ b/bin/genparser @@ -200,14 +200,14 @@ if [ "$verbose" = true ] ; then fi ${HDF5_FLEX} --nounistd -PH5LTyy -o ${path_to_hl_src}/H5LTanalyze.c ${path_to_hl_src}/H5LTanalyze.l -# fix H5LTparse.c and H5LTlparse.h to declare H5LTyyparse return type as an -# hid_t instead of int. Currently the generated function H5LTyyparse is -# generated with a return value of type int, which is a mapping to the +# Fix H5LTparse.c and H5LTparse.h to declare H5LTyyparse return type as an +# hid_t instead of int. Currently, the H5LTyyparse function is generated +# with a return value of type int, which is a mapping to the # flex yyparse function. The return value in the HL library should be # an hid_t. -# I propose to not use flex to generate this function, but for now I am -# adding a perl command to find and replace this function declaration in -# H5LTparse.c. +# A Perl command will be added to find and replace this function declaration +# in H5LTparse.c. This is a temporary solution until a method that does not +# use flex is implemented. perl -0777 -pi -e 's/int yyparse/hid_t yyparse/igs' ${path_to_hl_src}/H5LTparse.c perl -0777 -pi -e 's/int\nyyparse/hid_t\nyyparse/igs' ${path_to_hl_src}/H5LTparse.c perl -0777 -pi -e 's/int H5LTyyparse/hid_t H5LTyyparse/igs' ${path_to_hl_src}/H5LTparse.c From 7d27c1f3589a6d496e59d93d5b4572d1466a0b98 Mon Sep 17 00:00:00 2001 From: Hyo-Kyung Lee Date: Thu, 26 Sep 2024 16:33:05 -0500 Subject: [PATCH 2/2] address @lrknox review --- bin/genparser | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bin/genparser b/bin/genparser index 795ca8cd6a4..3e113739447 100755 --- a/bin/genparser +++ b/bin/genparser @@ -205,7 +205,7 @@ ${HDF5_FLEX} --nounistd -PH5LTyy -o ${path_to_hl_src}/H5LTanalyze.c ${path_to_hl # with a return value of type int, which is a mapping to the # flex yyparse function. The return value in the HL library should be # an hid_t. -# A Perl command will be added to find and replace this function declaration +# Use Perl command to find and replace this function declaration # in H5LTparse.c. This is a temporary solution until a method that does not # use flex is implemented. perl -0777 -pi -e 's/int yyparse/hid_t yyparse/igs' ${path_to_hl_src}/H5LTparse.c