Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zlib.h missing in binary MSI installer for Windows #3860

Closed
tbeu opened this issue Nov 16, 2023 · 3 comments
Closed

zlib.h missing in binary MSI installer for Windows #3860

tbeu opened this issue Nov 16, 2023 · 3 comments
Assignees
Labels
Component - Build CMake, Autotools Type - Task Actions that don't fit into any other type category

Comments

@tbeu
Copy link
Contributor

tbeu commented Nov 16, 2023

Describe the bug
The zlib.h is not (no longer) distributed with the MSI installers for Windows. I see that zconf.h is distributed, which somehow indicates that zlib.h should also be distributed.

Expected behavior
zlib.h should be distributed (as was the case for 1.8.12 installer).

Platform (please complete the following information)

  • HDF5 version 1.12.1 - 1.14.3
  • OS and version Win 10
  • Compiler and version MSVC
  • Build system (e.g. CMake, Autotools) and version CMake 3.27
@byrnHDF byrnHDF added Component - Build CMake, Autotools Type - Task Actions that don't fit into any other type category labels Nov 17, 2023
@byrnHDF
Copy link
Contributor

byrnHDF commented Nov 17, 2023

The compression lib APIs are not exposed by HDF5. The zconf.h file should not be distributed.

@tbeu
Copy link
Contributor Author

tbeu commented Nov 17, 2023

Thanks for the reply. In that case also libaec.h and szlib.h should not be distributed though it might break existing user workflows (as it did with missing zlib.h).

@derobins
Copy link
Member

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Build CMake, Autotools Type - Task Actions that don't fit into any other type category
Projects
None yet
Development

No branches or pull requests

3 participants