Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

H5Pset_external limited to offsets <= 2GB on Windows #3506

Closed
phil-opp opened this issue Sep 5, 2023 · 1 comment
Closed

H5Pset_external limited to offsets <= 2GB on Windows #3506

phil-opp opened this issue Sep 5, 2023 · 1 comment
Assignees
@derobins
Labels
Component - C Library Core C library issues (usually in the src directory) Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Type - Improvement Improvements that don't add a new feature or functionality
Milestone
2.0.0

Comments

@phil-opp
Copy link
Contributor

phil-opp commented Sep 5, 2023

Describe the bug
A clear and concise description of what the bug is.

The H5Pset_external function takes an offset argument of type off_t, which is a 32-bit signed integer on Windows. This makes it impossible to link to offsets > 2GB.

Interestingly, the only limitation seems to be the API definition. The implementation already uses a HDoff_t type for offsets, which is also 64-bit on Windows.

Expected behavior
A clear and concise description of what you expected to happen.

It should be possible to link to arbitrary offsets on Windows, like it is on Linux. The easiest solution for this would be to accept a 64-bit offset in the API on Windows.

Platform (please complete the following information)

  • HDF5 version (if building from a maintenance branch, please include the commit hash)
@phil-opp phil-opp mentioned this issue Sep 5, 2023
Merged
3 tasks
@glennsong09 glennsong09 added Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Component - C Library Core C library issues (usually in the src directory) Type - Improvement Improvements that don't add a new feature or functionality labels Sep 5, 2023
@derobins derobins self-assigned this Sep 11, 2023
@derobins derobins added this to the 1.14.4 milestone Oct 23, 2023
@derobins derobins modified the milestones: 1.14.4, Next Major Release Jan 19, 2024
@derobins derobins mentioned this issue Mar 9, 2024
Merged
@derobins derobins modified the milestones: Future Major Release, 2.0.0 Oct 29, 2024
@derobins
Copy link
Member

This has been fixed in develop and will appear in HDF5 2.0.0, scheduled for March 2025.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derobins derobins

Labels
Component - C Library Core C library issues (usually in the src directory) Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
3 participants
@derobins @phil-opp @glennsong09