Support pre/post_test_commands for host/guest #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostyanf14
requested changes
Sep 25, 2024
Jedoku
force-pushed
the
Support-pre-post-test-commands-for-host-guest
branch
from
767c7d9 to
86c457d
Compare
kostyanf14
reviewed
Sep 25, 2024
Jedoku
force-pushed
the
Support-pre-post-test-commands-for-host-guest
branch
from
86c457d to
71a83ee
Compare
akihikodaki
requested changes
Sep 30, 2024
kostyanf14
requested changes
Sep 30, 2024
Jedoku
force-pushed
the
Support-pre-post-test-commands-for-host-guest
branch
from
71a83ee to
281100a
Compare
kostyanf14
requested changes
Oct 3, 2024
Jedoku
force-pushed
the
Support-pre-post-test-commands-for-host-guest
branch
from
281100a to
a886161
Compare
akihikodaki
requested changes
Oct 7, 2024
Jedoku
force-pushed
the
Support-pre-post-test-commands-for-host-guest
branch
from
a886161 to
e926dfc
Compare
akihikodaki
requested changes
Oct 9, 2024
Jedoku
force-pushed
the
Support-pre-post-test-commands-for-host-guest
branch
from
e926dfc to
75a6240
Compare
akihikodaki
requested changes
Oct 10, 2024
Jedoku
force-pushed
the
Support-pre-post-test-commands-for-host-guest
branch
3 times, most recently
from
e8b35fb to
339c37a
Compare
akihikodaki
approved these changes
Oct 17, 2024
kostyanf14
requested changes
Oct 18, 2024
lib/engines/hcktest/hcktest.json
Outdated
| "desc": "Set Date for NdisStudio tests", | ||
| "guest_run": "Set-Date '1/1/2024 12:00:00 PM'" | ||
| } | ||
| ] |
There was a problem hiding this comment.
Drop this commit. You MUST set the correct time after these tests because it will cause issues on DF* tests, as we don't have ntpd server yet, so we can't use this solution for now.
| @@ -5,7 +5,7 @@ | |||
| "install_method": "PNP", | |||
There was a problem hiding this comment.
Don't use a long commit message title. The good practice to have the commit message title no longer than 72 characters. If this is needed you can add more information in the description.
Jedoku
force-pushed
the
Support-pre-post-test-commands-for-host-guest
branch
from
339c37a to
95656ea
Compare
This enhances readability and maintainability of the code by clearly indicating the phase during which these commands run. Signed-off-by: Vitalii Chulak <[email protected]>
Signed-off-by: Vitalii Chulak <[email protected]>
Signed-off-by: Vitalii Chulak <[email protected]>
Signed-off-by: Vitalii Chulak <[email protected]>
Jedoku
force-pushed
the
Support-pre-post-test-commands-for-host-guest
branch
from
95656ea to
2411e0b
Compare
kostyanf14
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.