You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This isn't an "issue" so much as a note I'd like to leave for others. Maybe a code change is warranted or a README update?
RepositoryEmpty.__contains__ is correctly implemented but __getitem__ returns None, which does not seem like an appropriate default value for app environment variables. Collections like a dictionary's __getitem__ will raise a KeyError instead.
Another alternative for an actually empty repository is to pass an empty dictionary instead of using RepositoryEmpty.
I don't know why RepositoryEmpty exists.
The text was updated successfully, but these errors were encountered:
This isn't an "issue" so much as a note I'd like to leave for others. Maybe a code change is warranted or a README update?
RepositoryEmpty.__contains__
is correctly implemented but__getitem__
returnsNone
, which does not seem like an appropriate default value for app environment variables. Collections like a dictionary's__getitem__
will raise aKeyError
instead.Another alternative for an actually empty repository is to pass an empty dictionary instead of using
RepositoryEmpty
.I don't know why
RepositoryEmpty
exists.The text was updated successfully, but these errors were encountered: