Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab names not showing correct directory with zsh #1853

Closed
amlamarra opened this issue May 21, 2021 · 11 comments · Fixed by #2073
Closed

Tab names not showing correct directory with zsh #1853

amlamarra opened this issue May 21, 2021 · 11 comments · Fixed by #2073

Comments

@amlamarra
Copy link

In Guake Preferences > Shell, I select /usr/bin/zsh as the "Default interpreter."
In Guake Preferences > Main Window, I have the following options set:
image

The terminal opens and shows the correct directory initially (my $HOME dir), but when I move around, the title is not updated.
image

Also, opening a new tab shows a tab title of Terminal.

This works as expected when I use /bin/bash as the "Default interpreter."


I'm using Ubuntu 20.04.2

$ guake --support

Guake Version: 3.7.1

Vte Version: 0.60.3

Vte Runtime Version: 0.60.3


GTK+ Version: 3.24.20

GDK Backend: GdkX11.X11Display


Desktop Session: xubuntu


Display: :0.0

RGBA visual: True

Composited: True

  • Monitor: 0 - Virtual1
    • Geometry: 1264 x 925 at 0, 0
    • Size: 334 x 245 mm²
    • Primary: True
    • Refresh rate: 60.00 Hz
    • Subpixel layout: horizontal-rgb
@trinaldi
Copy link
Contributor

This seems to be related to VTE. Tilix has the same issue

@Davidy22
Copy link
Collaborator

Davidy22 commented Sep 4, 2021

I'm on the latest git build with the same VTE version and I'm unable to reproduce the issue. If able, it'd be nice if you could confirm that the latest version in git works. if you can't be installing from source that's fine, but would like an update on next release to see if the issue is fixed for you there.

@amlamarra
Copy link
Author

I removed Guake and followed the instructions to install from source (https://guake.readthedocs.io/en/latest/user/installing.html#install-from-source). However, I still see the same issue. The version number doesn't seem to have changed:

15:39 ~ ❯ guake --version
Guake Terminal: 3.7.1
VTE: 0.60.3
VTE runtime: 0.60.3
Gtk: 3.24.20

@Davidy22
Copy link
Collaborator

Davidy22 commented Sep 4, 2021

Alright, still going to need more information to fix since I can't reproduce but I'll mark this as a bug for now.

@amlamarra
Copy link
Author

What info do you need?

@Davidy22
Copy link
Collaborator

Davidy22 commented Sep 6, 2021

Setting my preferences to the ones listed in the original screenshot didn't produce the bug for me so I think it's not among those, if there's any local setting you have that you think might be relevant that might be helpful. If you can find a setting anywhere that, when toggled, makes this stop occurring that'd go a long way to writing a general fix.

@trinaldi
Copy link
Contributor

trinaldi commented Sep 7, 2021

When I was looking into this, using pdb the variable didn't change accordingly. Changing to bash the issue went away.

~ ᐅ guake --version
Guake Terminal: 3.7.1
VTE: 0.64.2
VTE runtime: 0.64.2
Gtk: 3.24.30

EDIT: I took for granted that I'm using tmux. Out of curiosity I detached it and the tab bar seems to be working as expected.

NO tmux

  1. ~/bin folder

https://i.imgur.com/QJ7Oyge.png

  1. cd to dotfiles folder

https://i.imgur.com/vgRu4eI.png


As soon as I attach tmux:

  1. bin folder

https://i.imgur.com/fBkRgrW.png

  1. cd to dotfiles

https://i.imgur.com/dnkarjn.png


I hope that clarifies a bit.

@amlamarra
Copy link
Author

@Davidy22 I messed around with a bunch of options with /usr/bin/zsh as the Default Interpreter. However, I couldn't get it to change this behavior. I've screenshotted all my settings (except for keyboard shortcuts). Maybe you can find a difference between mine and yours.

guake1
guake2
guake3
guake4
guake5
guake6
guake7
guake8

@amlamarra
Copy link
Author

FYI, I finally fixed this by adding the following to my .zshrc file:

# Set the window title to the current directory
function precmd {
    echo -ne "\033]0;$(basename $(pwd))\a"
}

@Davidy22
Copy link
Collaborator

Had an idea recently and tested, I have oh my zsh enabled, tried disabling it and was able to reproduce. Quite possibly oh my zsh bundles something to the effect of your fix. Did some testing and seems like zsh doesn't send a signal that the terminal name is usually set on, looking into a fix

@trinaldi
Copy link
Contributor

By changing the .zshrc implies that it is something can be related to zsh, check out @amlamarra solution above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants