Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release before new Split-Terminal feature? #1411

Closed
aichingm opened this issue Sep 19, 2018 · 2 comments
Closed

Release before new Split-Terminal feature? #1411

aichingm opened this issue Sep 19, 2018 · 2 comments
Milestone

Comments

@aichingm
Copy link
Collaborator

aichingm commented Sep 19, 2018

Hey @gsemet,

I'm done implementing #71.

Two questions:

  1. As of now I would consider guake pretty stable. Since the new feature changes a lot of code again I thought maybe it is a good idea to to release a current version.

  2. Have you seen the bounty over on https://www.bountysource.com/issues/1324038-split-terminal-functionnality? Some one should claim it... (I would like to 😜 , BTW who is paying for the domain http://guake-project.org/?)

  • Splitting as deep as you want
  • Resize the split area with the mouse
  • New context menu entries for splitting and closing terminals
    image

Keybindings for:

  • Splitting horizontal and vertical
  • Moving the focus to the terminal above, below, left, or right
  • Resizing the terminals up, down, left and right
  • Closing a terminal
    image
@gsemet gsemet changed the title Realse before new Split-Terminal feature? Release before new Split-Terminal feature? Sep 20, 2018
@gsemet
Copy link
Member

gsemet commented Sep 20, 2018

Seem really cool ! Thanks for your work :)

Yes the bounty has just got 250$ a few days ago, I have no idea who is behind and even if it will work. So to answer you short: YES, I see no problem if you claim the bounty for your really helpful work the last months, this terminal backend rework enabling the split terminal and of course the GTK3 transition.

But I would be happy if you can consider a donation to the Guake project :) I am the one for the guake-project.org domain and hosting. Please contact me to my mail :)

I just released 3.3.3 as you suggested, with a small version increase since most changes you did are under the hood. So when you land your split terminal feature, so not forget the sem-ver: feature tag in your commit message.

I like the context menu entry, much like iterm2 does. Does it also support drag and droping the terminal to reorganize the notebook terms?

@gsemet gsemet modified the milestones: -- Next Version --, 3.3.3 Sep 20, 2018
@gsemet gsemet closed this as completed Sep 20, 2018
@aichingm
Copy link
Collaborator Author

But I would be happy if you can consider a donation to the Guake project :) I am the one for the guake-project.org domain and hosting. Please contact me to my mail :)

Yes, of course! I was thinking about a 50/50 split, since all I have done would be more or less useless without the work you have done for example on the build system.

There is no drag & drop support at the moment. I have to look in to drag & drop mechanisms in GTK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants