Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dual stacked monitor configuration misposition #1162

Closed
Confucij opened this issue Jan 24, 2018 · 10 comments · Fixed by #1167
Closed

Dual stacked monitor configuration misposition #1162

Confucij opened this issue Jan 24, 2018 · 10 comments · Fixed by #1167

Comments

@Confucij
Copy link

I'm using two 1080p monitors placed one over another. And when Guake located on bottom one - which is with a top bar - it's overlapped with a top bar. Details in the attached screenshot.
screenshot from 2018-01-24 15-57-07

@gsemet
Copy link
Member

gsemet commented Jan 24, 2018

that will be hard for me to dig it, only have 1 monitor :(

@Confucij
Copy link
Author

Maybe you could help and point me to code that responsible for window placement and I will dig it by myself?

@gsemet
Copy link
Member

gsemet commented Jan 24, 2018

guake_app.py function set_final_window_rect. It needs a complete rewrite, but if you document well your change and why you needed this change, it will help maintaining it

@Confucij
Copy link
Author

Thank you. I've managed to hack it for me:

        if window_rect.y != 0:
                window_rect.y = window_rect.y + 25;

I'll try to find a time to work on a solution for this.

@gsemet
Copy link
Member

gsemet commented Jan 25, 2018

hum, this is a generic enough solution, sadly. Where does these 25 pixels comes from? Title bar?

@Confucij
Copy link
Author

Yep, top panel height. I failed to found any other solution quick. Maybe there is some gtk3 function to find usable monitor space and not just its geometry.

On StackOverflow, someone suggests create a window, maximize it on a specified monitor, undecorate it, acquire its dimensions and use them as a usable screen space but this is definitely not a 2-minutes-fix.

@aichingm
Copy link
Collaborator

I'm working on a displacement setting right now which may fix this issue.

@Confucij
Copy link
Author

Confucij commented Jan 25, 2018

@aichingm Cool! I'm ready to help testing.

@aichingm
Copy link
Collaborator

@Confucij you can wait for the PR to be merged (#1167) or try it from my master branch at https://github.com/aichingm/guake

@igabaydulin
Copy link

Does #1167 fix an initial problem?

I have a similar problem. This is how it looks for a single display:
Screenshot from 2019-07-29 16-30-33

This is how it looks for multiple displays:
Screenshot from 2019-07-29 16-31-13
Screenshot from 2019-07-29 16-31-19

As you can see in both cases the placement is a little bit invalid. When a single display is used the displacement is calculated correctly (regarding launcher and top panel), maybe there is a way to apply displacement automatically for multiple displays too?

#1167 cannot be used when "Appear on mouse display" is enabled:
Screenshot from 2019-07-29 16-33-55
Screenshot from 2019-07-29 16-34-02

It applies displacement for both displays, when displacement is needed only for the right one.

Maybe it makes sense to open this issue back?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants