Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intro to the project #293

Open
atherdon opened this issue Apr 2, 2019 · 3 comments
Open

intro to the project #293

atherdon opened this issue Apr 2, 2019 · 3 comments

Comments

@atherdon
Copy link
Member

atherdon commented Apr 2, 2019

You need to read readme file: https://github.com/GroceriStar/groceristar-fetch/blob/master/README.md
it also contains links to articles, where I explaining some details. If something will be not clear - don't hesitate and ask questions.

Tasks, that you can take(feel free to ask clarification if something is not clear)

  1. In our previous major release we change a way how we connect to files. And after that changes, most of our default get methods become obsolete. They also start to generate an issue, because of naming conflict. So our goal with you will be to clean it up. First, part will be related to /projects/groceristar/groceristar.js file.

Here you can see our old methods. RIght now we don't need them.
https://github.com/GroceriStar/groceristar-fetch/blob/master/src/projects/GroceriStar/groceristar.js#L19-L38

But each of these methods used below in this file. So our goal is to remove them totally from this file, without breaking any logic.
I have feeling that this will be a simple task for you.

For example, this method contains old, commented version and working well without it
https://github.com/GroceriStar/groceristar-fetch/blob/master/src/projects/GroceriStar/groceristar.js#L103-L114

@adewale2018

@atherdon
Copy link
Member Author

atherdon commented Apr 3, 2019

I think i forget to put one link to this task - i updated task description

@atherdon
Copy link
Member Author

atherdon commented Apr 9, 2019

how things going? just ping you

@atherdon
Copy link
Member Author

@adewale2018 i plan to close this task if you're busy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant