Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update at getGroceriesWithDepIngKey tests #217

Open
6 tasks
atherdon opened this issue Feb 9, 2019 · 2 comments
Open
6 tasks

update at getGroceriesWithDepIngKey tests #217

atherdon opened this issue Feb 9, 2019 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed in-progress tests

Comments

@atherdon
Copy link
Member

atherdon commented Feb 9, 2019

file: https://github.com/GroceriStar/groceristar-fetch/blob/master/projects/GroceriStar/getGroceriesWithDepIngKey.test.js

  • tests that checking properties - move to a separated function. you can read our other test files and find a solution.

  • Right now these tests didn't cover a lot of cases. Try to jump on grocery.json and delete an id property. Try to delete name, make name an empty string. Delete all data from one object, only keep id, name(no departments, no ingredients inside)

  • ingredients for grocery lists stored at Ingredients folder. they connected via file name. just delete one of the files, that should be connected to grocery and you wouldn't see an error.

  • Test Deep structure takes 6000ms how to reduce this number?

  • we have test Ingredient by length? WTF it's doing and why we need it - please explain.

  • making grocery list name as empty string didn't generate an error

@shubhamrajput it's for you

@atherdon atherdon added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers in-progress tests labels Feb 9, 2019
@atherdon
Copy link
Member Author

@shubhamrajput any questions/updates?

@atherdon
Copy link
Member Author

@shubhamrajput please give me some updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed in-progress tests
Projects
None yet
Development

No branches or pull requests

2 participants