Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect docs example for custom filter component #844

Open
joshdcuneo opened this issue Dec 31, 2018 · 1 comment
Open

Incorrect docs example for custom filter component #844

joshdcuneo opened this issue Dec 31, 2018 · 1 comment

Comments

@joshdcuneo
Copy link

Griddle version

1.13.1

Expected Behavior

Custom filter component is passed onChange props to set filter as described in this example.

Actual Behavior

Custom filter component is passed setFilter props instead.

Steps to reproduce

Implement this example code using Griddle 1.13.1

class Filter extends Component {
  onChange(e) {
    this.props.onChange(e.target.value);
  }

  render() {
    return (
      <select onChange={this.onChange}>
        <option value="">All</option>
        <option value="Michigan">Michigan</option>
        <option value="Ohio">Ohio</option>
        <option value="Indiana">Indiana</option>
      </select>
    );
  }
}
...
<Griddle
  ...
  components={{
    Filter
  }}
/>

Pull request with failing test or storybook story with issue

While this step is not necessary, a failing test(s) and/or a storybook story will help us resolve the issue much more easily. Please see the README for more information.

Happy to submit a pull request if you can point me in the direction of the docs site repo.

@ryanlanciaux
Copy link
Member

Happy to submit a pull request if you can point me in the direction of the docs site repo.

That would be excellent! The docs repo is available here https://github.com/GriddleGriddle/griddle-docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants