Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings show even when it is "false" #816

Open
buildWithSoul opened this issue Jun 1, 2018 · 2 comments
Open

Settings show even when it is "false" #816

buildWithSoul opened this issue Jun 1, 2018 · 2 comments

Comments

@buildWithSoul
Copy link

Griddle version

latest version of griddle-react- followed steps listed on site

Expected Behavior

settings should not show, when settings={false} is passed in

Actual Behavior

settings shows regardless of whether boolean is passed in

Steps to reproduce

tested with simple Griddle component and data- settings still shows

Pull request with failing test or storybook story with issue

While this step is not necessary, a failing test(s) and/or a storybook story will help us resolve the issue much more easily. Please see the README for more information.

@buildWithSoul
Copy link
Author

Current workaround- passing in style config and set display to none for settings and settingstoggle

@dahlbyk
Copy link
Contributor

dahlbyk commented Jun 1, 2018

Try enableSettings={false}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants