Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 16 #736

Open
ryanlanciaux opened this issue Sep 7, 2017 · 9 comments
Open

React 16 #736

ryanlanciaux opened this issue Sep 7, 2017 · 9 comments

Comments

@ryanlanciaux
Copy link
Member

Griddle version

1.x

Expected Behavior

Griddle's storybook works with React 16

Actual Behavior

Griddle may be working but may have some things in some of the stories that are using deprecated features (this very well could be Griddle also).

Steps to reproduce

Pull request with failing test or storybook story with issue

No failing test.

@MichaelDeBoey
Copy link

Please update also to recompose ^0.25.1, which supports React ^16.0.0 🙂

@MichaelDeBoey
Copy link

@ryanlanciaux Any news on this one? 🙂

@dahlbyk
Copy link
Contributor

dahlbyk commented Nov 6, 2017

c8b6d16 pinned to [email protected]. Apparently there's a fix for v15 (DefinitelyTyped/DefinitelyTyped#21233), or we can address this only for v16.

@MichaelDeBoey
Copy link

@ryanlanciaux Any news on this one? 🙂

CC: @dahlbyk @joellanciaux

1 similar comment
@MichaelDeBoey
Copy link

@ryanlanciaux Any news on this one? 🙂

CC: @dahlbyk @joellanciaux

@bouzafr
Copy link

bouzafr commented Jan 24, 2018

Any news? recompose needs to be updated... thanks

@ryanlanciaux
Copy link
Member Author

I hope to address updating some of the dependencies early next week (unless someone beats me to it 👍 ) and would love to have a better strategy for managing them moving forward.

@andychongyz
Copy link

Any update?

@mDibyo
Copy link
Contributor

mDibyo commented Nov 5, 2018

Added a small PR upgrading recompose: #839

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants