Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use with React 15.5 or React 16 #720

Open
anshumanf opened this issue Aug 15, 2017 · 3 comments
Open

Use with React 15.5 or React 16 #720

anshumanf opened this issue Aug 15, 2017 · 3 comments

Comments

@anshumanf
Copy link
Contributor

Griddle version

0.8.1

Expected Behavior

No warnings or errors with React versions above 15.5

Actual Behavior

With React 15.5, the following warnings:

  • Warning: Accessing createClass via the main React package is deprecated, and will be removed in React v16.0. Use a plain JavaScript class instead. If you're not yet ready to migrate, create-react-class v15.* is available on npm as a temporary, drop-in replacement. For more info see https://fb.me/react-create-class
  • Warning: Accessing PropTypes via the main React package is deprecated, and will be removed in React v16.0. Use the latest available v15.* prop-types package from npm instead. For info on usage, compatibility, migration and more, see https://fb.me/prop-types-docs

Steps to reproduce

Any usage of this package will reproduce the above behavior.
Example: https://jsfiddle.net/anshumanf/v4qu94v6/

I'm currently on 0.8.1 and want to upgrade to React 16 which removes React.createClass(). I considered the following routes to make this work:

I want to keep using Griddle but this is a problem. Any ideas?

@AnthoniG
Copy link

I have this problem as well. Very annoying to see it splashed all over my console. Freaked me out at first lol

@mreishus
Copy link

I believe the branch is 'v0'. https://github.com/GriddleGriddle/Griddle/commits/v0

@MichaelDeBoey
Copy link

Will be fixed in #753

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants