Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After upgrading from 0.6 to 0.7 column metadata can no longer be set dynamically #558

Open
gidili opened this issue Feb 1, 2017 · 4 comments
Labels

Comments

@gidili
Copy link

gidili commented Feb 1, 2017

I had this problem in earlier versions (0.3), and when changing col meta with new columns and new custom controls etc I was nuking griddle with an unmount and then re-rendering from scratch rather than just triggering a re-render with the new col meta property as it should be.

This was gone in 0.6 and I was really happy about that, albeit if also resetting data dynamically I had to introduce a little delay between setting col meta and passing the new data into griddle to make it work (otherwise the behaviour was the same, new columns not being rendered).

Now after upgrading to 0.7 no matter what I do, delay or not, I cannot get griddle to see the new col meta. Probably gonna have to go back to nuking it since 0.7 solves other problems but it pains me greatly 😂

Any known workarounds to this?

@ryanlanciaux
Copy link
Member

Ouch. Sorry for introducing what appears to be a bug. I will have to look into this a little bit more to see what's going on.

Not sure of any work-arounds currently but will update if anything jumps out.

@gidili
Copy link
Author

gidili commented Feb 1, 2017

@ryanlanciaux appreciated! 👍

@pgilad
Copy link

pgilad commented Feb 19, 2017

Hey - this is a real killer for us, we change columns dynamically and in 0.6 got to immediately see the change, now Griddle doesn't propagate the change at all

@whiteb38
Copy link

any update on this? I am still seeing this issue in 0.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants