Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dangerous case sensitive filenames. #523

Closed
benedikt-schesch opened this issue Sep 14, 2023 · 3 comments
Closed

Dangerous case sensitive filenames. #523

benedikt-schesch opened this issue Sep 14, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@benedikt-schesch
Copy link
Contributor

Environment

  • Grid2op version: a819a77
  • System: osx

Bug description

File name which only have a case-sensitive distinction are being used, which is very dangerous and does not work correctly on OSX since HFS+ is case insensitive:
https://discussions.apple.com/thread/251231049

The file that have this problem are:
grid2op/Action/_backendAction.py and grid2op/Action/_BackendAction.py.

This is very dangerous and prevents OSX based developers to develop this code since these files collide.

@benedikt-schesch benedikt-schesch added the bug Something isn't working label Sep 14, 2023
@benedikt-schesch
Copy link
Contributor Author

I think this is relatively high priority bc it prevents ppl to work on the project correctly.

@BDonnot
Copy link
Collaborator

BDonnot commented Sep 15, 2023

Hello,

I thought this was only a problem on windows based OS and this problem can be solved (for users) by installing the whl python package (which works on all platforms I'm aware of).

This change has been done recently to be more compliant with python naming convention (and to avoid collision python side between the class _BackendAction and the file _BackendAction.py which is also quite terrible...) I did not thought (when making this change) that it would cause another issue. I'll try to think of a better solution that would allow:

  1. to be compliant with python naming convention
  2. to keep backward compatibility (things like from grid2op.Action._BaseAction import _BaseAction should work)
  3. does not cause any issue on mac os and windows

If you know one i'm happy to implement it asap.

Thanks for spotting it

Benjamin

BDonnot referenced this issue in BDonnot/Grid2Op Sep 15, 2023
BDonnot referenced this issue in BDonnot/Grid2Op Sep 15, 2023
This was referenced Sep 15, 2023
@benedikt-schesch
Copy link
Contributor Author

Thanks, I'll close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants