Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obs_sim.storage_max_p_absorb is None in sim2real env with Lightsim #518

Closed
marota opened this issue Sep 12, 2023 · 2 comments
Closed

obs_sim.storage_max_p_absorb is None in sim2real env with Lightsim #518

marota opened this issue Sep 12, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@marota
Copy link
Contributor

marota commented Sep 12, 2023

Environment

  • Grid2op version: 1.9.4
  • System: ubuntu 20.04.3 LTS, ...

Bug description

obs.storage_max_p_absorb attribute is None for a simulated obs when using a sim2real environment with LightSIm2grid backend

How to reproduce

Command line

# command line used if any 

Code snippet

from grid2op import make
from lightsim2grid import LightSimBackend

BACKEND = LightSimBackend
env=make("input_data_local_sim2real",backend=BACKEND()) #an env from sim2real track
obs,reward,done,info=env.step(env.action_space({}))
obs_simu,reward,done,info=obs.simulate(env.action_space({}),time_step=1)
assert(obs_simu.storage_max_p_absorb is not None)

I tried to reproduce also with env "l2rpn_case14_sandbox_diff_grid" but I don't get this behavior probably because there are no storage in the first place on that grid

Current output

obs_simu.storage_max_p_absorb is None

Expected output

obs_simu.storage_max_p_absorb should be the same as obs.storage_max_p_absorb
@marota marota added the bug Something isn't working label Sep 12, 2023
@marota
Copy link
Contributor Author

marota commented Sep 12, 2023

obs.storage_Emax is also impacted for simulation obs

BDonnot referenced this issue in BDonnot/Grid2Op Sep 12, 2023
BDonnot referenced this issue Sep 14, 2023
fixing issue rte-france#518
@BDonnot
Copy link
Collaborator

BDonnot commented Sep 19, 2023

fixed in version 1.9.5 (released a few minutes ago)

@BDonnot BDonnot closed this as completed Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants