Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Best_time and window_size are inverted at AlarmReward creation #229

Closed
marota opened this issue Jun 16, 2021 · 3 comments
Closed

Best_time and window_size are inverted at AlarmReward creation #229

marota opened this issue Jun 16, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@marota
Copy link
Contributor

marota commented Jun 16, 2021

Environment

  • Grid2op version: 1.6.0
  • System: osx
  • Additional system information

Bug description

Best_time and window_size are inverted at AlarmReward creation

How to reproduce

see here:
https://github.com/rte-france/Grid2Op/blob/e19cb7590d3fcd697972aaabfb2a3bcff4b3f0e1/grid2op/Reward/AlarmReward.py#L71
@marota marota added the bug Something isn't working label Jun 16, 2021
BDonnot referenced this issue in BDonnot/Grid2Op Jun 17, 2021
@BDonnot
fixing issue rte-france#229
1e6ca00
@marota
Copy link
Contributor Author

marota commented Jun 17, 2021

A suggestion for improvement here: rather than -1, use self.reward_min ?

https://github.com/rte-france/Grid2Op/blob/e19cb7590d3fcd697972aaabfb2a3bcff4b3f0e1/grid2op/Reward/AlarmReward.py#L154

=> best_score, is_alarm_used = self.reward_min, False

@BDonnot
Copy link
Collaborator

BDonnot commented Jun 17, 2021

I don't get it, this reward returns a score between -1 and 1 so -1 and reward_min are the same, no ?

BDonnot referenced this issue in BDonnot/Grid2Op Jun 17, 2021
@BDonnot
minor improvment, see rte-france#229
e463b7b
@BDonnot
Copy link
Collaborator

BDonnot commented Jun 22, 2021

Fixed and merged in version 1.6.0, now available on pypi

@BDonnot BDonnot closed this as completed Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marota @BDonnot