Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ghost circuit slot scroll input #2373

Merged
merged 6 commits into from
Nov 17, 2024

Conversation

omergunr100
Copy link
Contributor

@omergunr100 omergunr100 commented Nov 15, 2024

What

Adds the ability to scroll over the circuit slot tab button to change circuit number without clicking it, also middle click resets it to "no circuit".

Handles #2349.

Implementation Details

Adds more IFancy* functional interfaces which are used in overrides in the ConfigurationPanel.Tab class, each specifies a function.

Outcome

idk, it works, I guess.

Additional Information

Recording 2024-11-15 120238

@omergunr100 omergunr100 requested a review from a team as a code owner November 15, 2024 10:07
@omergunr100 omergunr100 marked this pull request as draft November 15, 2024 10:08
@omergunr100 omergunr100 changed the title 1.20.1 circuit scroll Add ghost circuit slot scroll input Nov 15, 2024
@omergunr100
Copy link
Contributor Author

ok, tested it on a dedicated server and it still works and persists

@omergunr100 omergunr100 marked this pull request as ready for review November 15, 2024 18:40
@YoungOnionMC YoungOnionMC added the type: feature New feature or request label Nov 17, 2024
@screret screret linked an issue Nov 17, 2024 that may be closed by this pull request
@YoungOnionMC YoungOnionMC merged commit 36188c6 into GregTechCEu:1.20.1 Nov 17, 2024
4 checks passed
@omergunr100 omergunr100 deleted the 1.20.1-circuit-scroll branch November 17, 2024 11:10
@Ray661
Copy link

Ray661 commented Nov 17, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to Scroll the Circuit Settings in Machines
3 participants