Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide nested manifests and manifests covering edge-case scenarios for phased execution #912

Closed
2 tasks done
Tracked by #762
zanete opened this issue Jul 15, 2024 · 6 comments · Fixed by #915
Closed
2 tasks done
Tracked by #762
Assignees

Comments

@zanete
Copy link

zanete commented Jul 15, 2024

Why: Sub of #762

What: Support the development of #809 with nested manifests and other manifests covering edge case scenarios

Scope of work:

  • manifests/examples/pipelines/nesting.yml
  • manifests/examples/pipelines/pipeline-with-mocks.yml
@zanete zanete mentioned this issue Jul 15, 2024
6 tasks
@zanete zanete moved this to In Design in IF Jul 15, 2024
@zanete zanete moved this from In Design to In Refinement in IF Jul 15, 2024
@zanete
Copy link
Author

zanete commented Jul 15, 2024

cc @jmcook1186 FYI here is the issue about manifests specific to phased execution development

@zanete zanete added this to the Inputs and Outputs milestone Jul 15, 2024
@zanete zanete added blocked The issue is blocked and cannot proceed. and removed blocked The issue is blocked and cannot proceed. labels Jul 15, 2024
@jmcook1186
Copy link
Contributor

Issue is that every manifest in our examples folder is supposed to have at least one corresponding file in the ouputs folder - a success case and ideally at least one negative/failure case.

@zanete
Copy link
Author

zanete commented Jul 16, 2024

As discussed in the standup, After @narekhovhannisyan changes the old manifests will be broken and not usable for the phased execution, so we will have to rework all of the examples and outputs. There is an issue #812 to handle this.
The scope of this issue is to provide the minimal set of manifests for @narekhovhannisyan to continue development, for example:

  • manifests/examples/pipelines/nesting.yml
  • manifests/examples/pipelines/pipeline-with-mocks.yml

@zanete
Copy link
Author

zanete commented Jul 16, 2024

@MariamKhalatova please confirm you are able to help with this and the requirement is clear? if not, please consult @narekhovhannisyan

@MariamKhalatova
Copy link
Contributor

@zanete I have updated these manifests locally, however I'm blocked by @narekhovhannisyan since he hasn't pushed his changes yet. Waiting for him to publish the branch.

@MariamKhalatova MariamKhalatova moved this from In Refinement to In Progress in IF Jul 16, 2024
@zanete zanete moved this from In Progress to Pending Review in IF Jul 18, 2024
@zanete
Copy link
Author

zanete commented Jul 18, 2024

there's currently an issue with dependency on time sync which needs to be resolved in order to merge it, @manushak and @narekhovhannisyan to have a sync about this

@narekhovhannisyan narekhovhannisyan linked a pull request Jul 20, 2024 that will close this issue
9 tasks
@zanete zanete closed this as completed Jul 22, 2024
@github-project-automation github-project-automation bot moved this from Pending Review to Done in IF Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants