Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove params.ts and related logic from IF #814

Closed
4 tasks done
Tracked by #761
zanete opened this issue Jun 11, 2024 · 3 comments · Fixed by #908
Closed
4 tasks done
Tracked by #761

Remove params.ts and related logic from IF #814

zanete opened this issue Jun 11, 2024 · 3 comments · Fixed by #908
Assignees
Labels
core-only This issue is reserved for the IF core team only

Comments

@zanete
Copy link

zanete commented Jun 11, 2024

Why: Sub of #761
What: Remove params.ts and related logic from IF

prerequisites

IF must get aggregation information from context-level manifest config before params.ts is removed.

Scope of work:

  • Delete params.ts file from IF
  • Remove logic from IF that checks params.ts

Acceptance criteria

  • params.ts is removed from IF

  • IF runs as expected without params.ts being available

    GIVEN params logic is removed from IF
    WHEN I run the manifests in our examples and outputs folders
    THEN all manifest execute as expected

@zanete zanete added this to the Inputs and Outputs milestone Jun 11, 2024
@zanete zanete moved this to In Design in IF Jun 11, 2024
@zanete zanete added draft The issue is still being written, no need to respond or action on anything. core-only This issue is reserved for the IF core team only labels Jun 11, 2024
@jmcook1186 jmcook1186 moved this from In Design to In Refinement in IF Jun 14, 2024
@zanete zanete removed the draft The issue is still being written, no need to respond or action on anything. label Jun 14, 2024
@zanete
Copy link
Author

zanete commented Jun 14, 2024

@manushak @narekhovhannisyan please review AC to see if it all looks good

@manushak manushak removed their assignment Jun 26, 2024
@narekhovhannisyan
Copy link
Member

for this one please make sure that CLI custom params feature is also included

@narekhovhannisyan narekhovhannisyan removed their assignment Jun 27, 2024
@zanete zanete moved this from In Refinement to Ready in IF Jun 27, 2024
@manushak manushak moved this from Ready to In Progress in IF Jul 9, 2024
@manushak manushak moved this from In Progress to Ready in IF Jul 9, 2024
@manushak manushak moved this from Ready to In Progress in IF Jul 10, 2024
@zanete zanete moved this from In Progress to Blocked in IF Jul 11, 2024
@zanete zanete added the blocked The issue is blocked and cannot proceed. label Jul 11, 2024
@manushak manushak moved this from Blocked to In Progress in IF Jul 11, 2024
@manushak manushak moved this from In Progress to Pending Review in IF Jul 11, 2024
@zanete zanete removed the blocked The issue is blocked and cannot proceed. label Jul 12, 2024
@zanete
Copy link
Author

zanete commented Jul 15, 2024

@narekhovhannisyan please review linked PR #911

@zanete zanete moved this from Pending Review to Testing in IF Jul 16, 2024
@manushak manushak linked a pull request Jul 17, 2024 that will close this issue
9 tasks
@manushak manushak moved this from Testing to Done in IF Jul 17, 2024
@zanete zanete closed this as completed Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-only This issue is reserved for the IF core team only
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants