-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove params.ts
and related logic from IF
#814
Labels
core-only
This issue is reserved for the IF core team only
Milestone
Comments
zanete
added
draft
The issue is still being written, no need to respond or action on anything.
core-only
This issue is reserved for the IF core team only
labels
Jun 11, 2024
This was referenced Jun 11, 2024
Closed
Closed
zanete
removed
the
draft
The issue is still being written, no need to respond or action on anything.
label
Jun 14, 2024
@manushak @narekhovhannisyan please review AC to see if it all looks good |
for this one please make sure that CLI custom params feature is also included |
@narekhovhannisyan please review linked PR #911 |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Why: Sub of #761
What: Remove
params.ts
and related logic from IFprerequisites
IF must get aggregation information from context-level manifest config before
params.ts
is removed.Scope of work:
params.ts
file from IFparams.ts
Acceptance criteria
params.ts
is removed from IFIF runs as expected without
params.ts
being availableGIVEN params logic is removed from IF
WHEN I run the manifests in our examples and outputs folders
THEN all manifest execute as expected
The text was updated successfully, but these errors were encountered: