Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output file is not generated if manifest is invalid #701

Closed
Tracked by #592 ...
MariamKhalatova opened this issue May 7, 2024 · 2 comments
Closed
Tracked by #592 ...

Output file is not generated if manifest is invalid #701

MariamKhalatova opened this issue May 7, 2024 · 2 comments
Assignees
Milestone

Comments

@MariamKhalatova
Copy link
Contributor

Description of the Error

Output file with error is not saved if manifest structure is invalid.

Expected Behaviour

If manifest structure is invalid, output file should be saved and the validation error should be present in the execution.error.

Actual Behaviour

Error is shown in console, no output file is saved.

Steps to Reproduce

  1. Run the manifest provided below.

Link to online environment

Manifest File That Generated the Error

name: basic
description: a minimal manifest executing a single plugin on a single component for a single timestep
tags:
initialize:
  outputs: ['yaml']
  plugins:
    teads-curve: 
      path: '@grnsft/if-unofficial-plugins'
      # method: TeadsCurve
      global-config:
        interpolation: spline
tree:
  children:
    child-0:
      defaults:
        cpu/thermal-design-power: 100
      pipeline:
        - teads-curve
      inputs:
        - timestamp: 2023-07-06T00:00
          duration: 1
          cpu/utilization: 70
        - timestamp: 2023-07-06T00:01
          duration: 1
          cpu/utilization: 80
        - timestamp: 2023-07-06T00:02
          duration: 1
          cpu/utilization: 20

Command:

npm run ie -- --manifest manifests/examples/basic.yml --output manifests/outputs/basic

Links to Any Additional Code

Screenshot 2024-05-07 at 6 28 06 PM

Runtime Info

macos, node 18

@MariamKhalatova MariamKhalatova added the bug Error, flaw or fault label May 7, 2024
@zanete zanete moved this to Ready in IF May 7, 2024
@zanete
Copy link

zanete commented May 7, 2024

Will be fixed by #592

@zanete zanete added this to the Automated Testing milestone May 7, 2024
@zanete zanete added qa and removed bug Error, flaw or fault labels May 7, 2024
@narekhovhannisyan narekhovhannisyan mentioned this issue May 8, 2024
9 tasks
@jmcook1186 jmcook1186 moved this from Ready to Pending Review in IF May 8, 2024
@zanete zanete moved this from Pending Review to Testing in IF May 10, 2024
@MariamKhalatova
Copy link
Contributor Author

fixed by #691

@github-project-automation github-project-automation bot moved this from Testing to Done in IF May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants