Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to .NET 8 #493

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

YaSuenag
Copy link
Member

@YaSuenag YaSuenag requested a review from vaughanknight as a code owner March 27, 2024 08:03
@YaSuenag
Copy link
Member Author

I don't know why DCO failed - I've added DCO as following picture.

スクリーンショット 2024-03-27 170414

@YaSuenag YaSuenag mentioned this pull request Mar 27, 2024
6 tasks
@YaSuenag
Copy link
Member Author

We can ignore the failure in api-comparison because it failed in .NET 6 setup in GHA workflow - this PR depends on .NET 8 only.

This PR do not change any WebAPIs.

@danuw
Copy link
Collaborator

danuw commented Apr 3, 2024

LGTM - as discussed previously, API comparison error is expected and DCO needs to be overwritten here...
Thanks @YaSuenag

@danuw danuw merged commit fd6db72 into Green-Software-Foundation:dev Apr 3, 2024
8 of 9 checks passed
@YaSuenag YaSuenag deleted the pr/dotnet8 branch April 3, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants