-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Contribution]: Publish the docker file in a docker registry #262
Comments
Right now we have to do something like this: FROM mcr.microsoft.com/dotnet/sdk:6.0 AS build-env
RUN wget https://github.com/Green-Software-Foundation/carbon-aware-sdk/archive/refs/tags/v1.0.0.zip
RUN apt-get update && \
apt-get install unzip && \
unzip v1.0.0.zip && \
rm v1.0.0.zip
WORKDIR /carbon-aware-sdk-1.0.0/src
RUN dotnet publish CarbonAware.WebApi/src/CarbonAware.WebApi.csproj -c Release -o publish
FROM mcr.microsoft.com/dotnet/aspnet:6.0
WORKDIR /carbon-aware-sdk-1.0.0/src
COPY --from=build-env /carbon-aware-sdk-1.0.0/src/publish .
ENTRYPOINT ["dotnet", "CarbonAware.WebApi.dll"] A few things would be a massive improvement in using the library:
Thanks for this great repo though, it's really amazing. |
This issue has not had any activity in 120 days. Please review this issue and ensure it is still relevant. If no more activity is detected on this issue for the next 20 days, it will be closed automatically. |
Hi, thank you for those comments and sorry for the delay. We are in the process of making some of those changes, but feel free to create pull request or send links if there is anything missing. (Do you have a link for the scenario to publish registry to a container or what we have in the repo is enough now please? |
You already can pull WebAPI container image from GitHub Packages. Is it enough? https://github.com/Green-Software-Foundation/carbon-aware-sdk/pkgs/container/carbon-aware-sdk |
This issue has not had any activity in 120 days. Please review this issue and ensure it is still relevant. If no more activity is detected on this issue for the next 20 days, it will be closed automatically. |
I think we can close this issue. |
This issue has not had any activity in 120 days. Please review this issue and ensure it is still relevant. If no more activity is detected on this issue for the next 20 days, it will be closed automatically. |
Closing because we use GitHub Packages to publish WebAPI container image. |
What happened?
It would be good to publish the docker image to a docker registry (e.g. GitHub Packages) so we could just consume and pass in the version of the sdk.
Code of Conduct
Feature Commitment
The text was updated successfully, but these errors were encountered: