Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISW - Wizard Step: Input Diagnostics #20683

Open
grotlue opened this issue Oct 11, 2024 · 6 comments · May be fixed by #21184
Open

ISW - Wizard Step: Input Diagnostics #20683

grotlue opened this issue Oct 11, 2024 · 6 comments · May be fixed by #21184
Assignees

Comments

@grotlue
Copy link
Contributor

grotlue commented Oct 11, 2024

Issue for building the diagnostics page.

  • Shows a status of the input with
    • Input name
    • Input description (stretch goal)
    • node it is running on
    • input specific details (only for listener inputs)
      • bind address (if available)
      • port (if available)
      • show info copy to check if UCP or TCP
  • Shows a button "Show Received Messages"
    • clicking on it will forward you to the search page
    • already exists: Image

Input Test Results

Metrics:

  • if any metric does not exist we show 0
  • we will use the fifteen_minute property of the metrics rate object
  • the metrics are automatically refetched every 5 seconds
  • we will show an UI element that can manually trigger a refresh of the metrics
  • Throughput (already exists): Image
  • Message error at input
  • Message failed to process
  • Message failed to index
  • Input state and detailed message(already exists in input state)
    • We show a summary of existing states of all nodes of this input (e.g.: FAILED: 2/10, RUNNING: 8/10)
      • When clicking on each state, the list expands, showing the related node ids
      • if a detailed message exists, the node id can be clicked to show it
  • Messages received by input count
    • Descriptional text of that this metric represents
  • Streams count and stream names ( count query for gl2_source_input and stream)

Mock-Up

Image

@grotlue grotlue changed the title Wizard Step: Test Input Placeholder Wizard Step: Input Diagnostics Nov 6, 2024
@grotlue
Copy link
Contributor Author

grotlue commented Nov 12, 2024

To show the input name and a type specific description we will need an additional call returning input name and description based on a given type.

@grotlue
Copy link
Contributor Author

grotlue commented Nov 12, 2024

@AntonEbel Do you know if we have the information TCP or UCP for listener inputs? bind address and port I can find in the form.

@AntonEbel
Copy link
Contributor

@grotlue No, we do not provide this information and do not persist it. I don't know if we want to display this explicitly because the TCP/UDP protocol is already included in the Input Type name.

@patrickmann
Copy link
Contributor

Agree with @anton that there is not a lot of value in adding the TCP/UDP detail.

We can use existing metrics APIs for all of the numbers. So what is left that backend needs to expose? This part seems to have some new information:

We show a summary of existing states of all nodes of this input (e.g.: FAILED: 2/10, RUNNING: 8/10)
When clicking on each state, the list expands, showing the related node ids
if a detailed message exists, the node id can be clicked to show it
Messages received by input count ( Opensearch count query for gl2_source_input)
Streams count and stream names ( count query for gl2_source_input and stream)

@grotlue
Copy link
Contributor Author

grotlue commented Nov 12, 2024

@grotlue No, we do not provide this information and do not persist it. I don't know if we want to display this explicitly because the TCP/UDP protocol is already included in the Input Type name.

Agree with @anton that there is not a lot of value in adding the TCP/UDP detail.

@tellistone What is your take on the TCP/UDP detail?

@tellistone
Copy link

tellistone commented Nov 12, 2024

could be replaced with a line of ui copy reminding the user to check they are using the right one re: TCP/UDP

Users trip over this a surprising amount (perhaps because the app gives no feedback when this is happening)

@tellistone tellistone changed the title Wizard Step: Input Diagnostics ISW - Wizard Step: Input Diagnostics Nov 14, 2024
@gally47 gally47 self-assigned this Dec 12, 2024
@gally47 gally47 linked a pull request Dec 13, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants