Add upgrade support and improve windows installer #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The installer can now also upgrade existing sidcar installations. It detects this by the presence of an existing sidecar.yml config. In upgrade mode it skip the configuration page. Additionally the installer will now also register the sidecar service automatically. Making this extra command line step obsolete. For debugging purposes, we write a installerlog.txt file now. Improve welcome message test to also show the version and mention the autmatic upgrade mode. Only replace the winlogbeat and filebeat collector binaries AFTER we stopped the sidecar. Otherwise the files might still be locked and the upgrade fails.
Also fix default node-id file location for 32-bit installs
We need to start the service AFTER we've written the final sidecar.yml Also using nsExec allows us to see the output of the service command.
thll
requested changes
Oct 4, 2022
|
@mpfz0r Depends on how hard it is to fix. A few hours during this cool-down seem ok to me. |
thll
approved these changes
Oct 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The installer can now also upgrade existing sidcar installations.
It detects this by the presence of an existing sidecar.yml config.
In upgrade mode it skip the configuration page.
Additionally the installer will now also register the sidecar
service automatically. Making this extra command line step obsolete.
For debugging purposes, we write a installerlog.txt file now.
Improve welcome message test to also show the version and mention the
autmatic upgrade mode.
Only replace the winlogbeat and filebeat collector binaries AFTER
we stopped the sidecar. Otherwise the files might still be locked
and the upgrade fails.
Suppport
-NODEID paramfor silent installerAlso fix default node-id file location for 32-bit installs
Fixes #365
Fixes #432