Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make validation timeout configurable #435

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Make validation timeout configurable #435

merged 1 commit into from
Aug 2, 2022

Conversation

mpfz0r
Copy link
Contributor

@mpfz0r mpfz0r commented Aug 1, 2022

Intoduce a new config option: collector_validation_timeout = 1m
Also increase the default timeout from 30s to 1m
since 30s seems to low for some use cases.

Fixes #431

Intoduce a new config option: `collector_validation_timeout = 1m`
Also increase the default timeout from 30s to 1m
since 30s seems to low for some use cases.

Fixes #431
@mpfz0r mpfz0r requested a review from bernd August 1, 2022 15:15
Copy link
Member

@bernd bernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 (untested, though)

@mpfz0r mpfz0r merged commit 56bd153 into master Aug 2, 2022
@mpfz0r mpfz0r deleted the issue-431 branch August 2, 2022 09:02
mpfz0r added a commit that referenced this pull request Aug 2, 2022
Intoduce a new config option: `collector_validation_timeout = 1m`
Also increase the default timeout from 30s to 1m
since 30s seems to low for some use cases.

Fixes #431

(cherry picked from commit 56bd153)
mpfz0r added a commit that referenced this pull request Aug 2, 2022
Intoduce a new config option: `collector_validation_timeout = 1m`
Also increase the default timeout from 30s to 1m
since 30s seems to low for some use cases.

Fixes #431

(cherry picked from commit 56bd153)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graylog sidecar validate runs only 30 seconds
2 participants