Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encrypt usb medias like sd cards natively #4500

Open
Lppsoeht opened this issue Dec 12, 2024 · 2 comments
Open

Encrypt usb medias like sd cards natively #4500

Lppsoeht opened this issue Dec 12, 2024 · 2 comments
Labels
enhancement New feature or request priority-low

Comments

@Lppsoeht
Copy link

Lppsoeht commented Dec 12, 2024

At least a while ago it was pretty easy to encrypt a SD card, I don't know about the current implementation if there's still one.
It would help, since newer pixels don't have a SD storage slot, to encrypt any USB storage device as it were a SD card.
(I don't really care if it won't be readable across other operative systems due to hardware-based encryption, maybe it's better this way)

@thestinger thestinger added the enhancement New feature or request label Dec 12, 2024
@secretmango
Copy link

This sounds like a really good idea.

Fixing the implementation to use LUKS and storing the key in the keystore would be better. But as it is, this FR sounds like it could be pretty close to vanilla AOSP features.

@thestinger
Copy link
Member

Storing the key in the hardware keystore isn't a good approach. We would just use the same kind of encryption approach as the OS does for data if we did this, but with a single key for all metadata and data blocks with the same kind of credential-based key derivation for it. We could even potentially dedicate a Weaver slot to it but it wouldn't be possible to do that for more than a very limited amount. Not clear we want to implement this, but it's a possibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority-low
Projects
None yet
Development

No branches or pull requests

3 participants