Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

if a dataset has multiple edges between the same source and target node, the user should provide an ID for the edge (or else)... #259

Closed
hdngr opened this issue Jul 29, 2014 · 2 comments

Comments

@hdngr
Copy link
Contributor

hdngr commented Jul 29, 2014

or else things won't work in edge captioning and filtering...

Realistically, Alchemy.js as a client application should not be burdened with teasing out unique edges. If someone was smart enough to get a data set with rich, diverse relationships between the same source and target node, they should be smart enough to provide Alchemy.js with a unique id for the edge.

Therefore, all edge ids will be defined with the logic:

if edge.id
    edge.id = edge.id
else
    edge.id = "#{edge.source.id}-#{edge.target.id}"

sound good?

cc: @mdcox @ifjorissen

@hdngr hdngr added this to the v0.2 milestone Jul 29, 2014
@hdngr hdngr added bug labels Jul 29, 2014
@ghost
Copy link

ghost commented Jul 29, 2014

Sounds good to me, we just need to make it excessively clear in the documentation.

@ghost
Copy link

ghost commented Jul 30, 2014

Another idea we were talking about was having the ID be source-relationship-target, since it's unlikely (except with temporal or chemical data I suppose) that there would be duplicates.

@ghost ghost self-assigned this Aug 13, 2014
@hdngr hdngr modified the milestones: v0.2, v0.2.1 Release Aug 19, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant