Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems when with grapesjs-present-newsletter plugin #353

Closed
matiponce91 opened this issue Sep 29, 2017 · 3 comments
Closed

Problems when with grapesjs-present-newsletter plugin #353

matiponce91 opened this issue Sep 29, 2017 · 3 comments
Labels

Comments

@matiponce91
Copy link

Hi All,
I am trying to use GrapesJs with grapesjs-present-newsletter plugin so I can show HTML with inside CSS. So I installed the plugin through npm and then imported the library inside index.html. Finally within "grapes.init ()" I added the following code:

plugins: ['gjs-preset-newsletter'],
       pluginsOpts: {
           'gjs-preset-newsletter': {
         		inlineCss: true,
         		modalLabelImport: 'Paste all your code here below and click import',
 			modalLabelExport: 'Copy the code and use it wherever you want',
           }
 }

but "inlineCss" (it doesn't matter if its value is true or false ) and "modalLabelExport" don't work, showing the "Export modal" as it is configured on grapes core (two blocks, one for HTML and one for CSS). And for example "modalLabelImport" or any other property, that is not related to export modal, work perfectly fine.

@artf
Copy link
Member

artf commented Sep 29, 2017

Fixed and published a new release, thanks for the catch

@matiponce91
Copy link
Author

can you check this commit #356?

@lock
Copy link

lock bot commented Sep 18, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot added the outdated label Sep 18, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants