Skip to content

Commit

Permalink
build: node: Pin node-gyp==^9.4.1
Browse files Browse the repository at this point in the history
node-gyp 10.x.x was released recently, and our build started failing with this error:

	16.93 gyp ERR! configure error
	16.93 gyp ERR! stack TypeError: Cannot read property 'pipeline' of undefined

Pinning to 9.x.x helps.
  • Loading branch information
Jongy committed Nov 22, 2023
1 parent cfd9ec1 commit 54b1d48
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/build_node_package.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ git clone https://github.com/mmarchini-oss/node-linux-perf.git $MODULE_PATH
cd $MODULE_PATH
git reset --hard $GIT_REV

npm install -g node-gyp
npm install -g node-gyp@^9.4.1 # pinned, as 10.x.x was broken, see my commit message
curl -L https://github.com/nodejs/nan/archive/refs/tags/v2.16.0.tar.gz -o nan.tar.gz
tar -vxzf nan.tar.gz -C /tmp
NAN_PATH=$(realpath /tmp/nan-*)
Expand Down

0 comments on commit 54b1d48

Please sign in to comment.