Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broke GPP connection #118

Closed
Buom01 opened this issue Dec 18, 2020 · 1 comment
Closed

Broke GPP connection #118

Buom01 opened this issue Dec 18, 2020 · 1 comment

Comments

@Buom01
Copy link
Member

Buom01 commented Dec 18, 2020

Hi,

I noticed that I have broke compatibility with GPP server with the following line:
https://github.com/Buom01/tremulous/blame/647bc2bae35e6ac1ccd74479b123bc60ade5a446/src/game/bg_public.h#L86
in the merged pull request: #104

Connecting to 1.1.0 servers isn't affected at all.

Symptoms:
Wrong songs, and other weird stuff on GPP servers.

A word about the broke:
It were introduced by implanting a graphical team status with a bad design: I should have used cvar instead of touching CS_*.
Even if I did all my code with compatibility in mind I only noticed it while trying to open a GPP server.
That's also because I shouldn't mix so different things in a single pull request... which made it harder to review also because GitHub's filters are almost useless too.

I will patch it when I have free time, and when I found a workaround for gcc-10 (I will open issues for it too).
It would be changed to allow the server to get some enhancement, and will be like not existent if the server is not patched (at server side only): "Progressive".

@Buom01
Copy link
Member Author

Buom01 commented Dec 29, 2020

Close as it would be fixed on #121
No real solution found except reverting it (as it would need custom QVM else)

@Buom01 Buom01 closed this as completed Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant