Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix more CC compatibility issues #835

Closed
wants to merge 8 commits into from
Closed

Fix more CC compatibility issues #835

wants to merge 8 commits into from

Conversation

Goooler
Copy link
Member

@Goooler Goooler commented Feb 28, 2023

I missed something in #763 & #775, cause --configuration-cache flag hadn't been applied for all plugin tests, now fixed all of them.

Follow up #824.

@Goooler
Copy link
Member Author

Goooler commented Feb 28, 2023 •
edited
Loading

We should note these behavior changes in README or Changelog, something like

  1. Replacing ConfigureShadowRelocation with ShadowJar, link ConfigureShadowRelocation task is not resolvable in 8.1.0 #834.
  2. If you are using custom Transformers, disable CC in shadowJar.
  3. Add Project as ShadowExtension.component's param.

@Goooler Goooler mentioned this pull request Feb 28, 2023
Closed
@Goooler Goooler marked this pull request as draft March 2, 2023 02:53
@Goooler Goooler marked this pull request as ready for review March 2, 2023 18:16
@Goooler Goooler mentioned this pull request Mar 3, 2023
Closed
@Goooler
Copy link
Member Author

Goooler commented Mar 4, 2023

@eskatos Can you take a look?

@Goooler Goooler marked this pull request as draft March 6, 2023 15:02
@Goooler Goooler force-pushed the enable_cc_for_all_test branch from 2ff2ae1 to a86645c Compare March 9, 2023 02:10
@Goooler Goooler marked this pull request as ready for review March 9, 2023 02:11
@Goooler
Copy link
Member Author

Goooler commented Mar 9, 2023

@johnrengelman Can we merge this and publish a new version?

@johnrengelman
Copy link
Collaborator

I should be able to get to it tomorrow.
thanks for all the contributions!

@Goooler
Copy link
Member Author

Goooler commented Mar 19, 2023

@johnrengelman Any updates?

@johnrengelman johnrengelman added this to the 8.1.1 milestone Mar 20, 2023
@johnrengelman
Copy link
Collaborator

johnrengelman commented Mar 20, 2023 •
edited
Loading

manually rebased and merged into master (see 960617f)

@johnrengelman
Copy link
Collaborator

Releasing this today @Goooler. Thanks!
Also, i've switch the repo to now use main. Make sure to updated your tracking branches.

@Goooler Goooler deleted the enable_cc_for_all_test branch March 21, 2023 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eskatos eskatos eskatos left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@Goooler @johnrengelman @eskatos