We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6.1.0
6.3
A project with application and shadow plugins applied. The project makes use of Java modules, thus mainClassName is set to
application
shadow
mainClassName
ext.moduleName = 'org.kordamp.ikonli.browser' ext.moduleMainClass = 'org.kordamp.ikonli.browser.Launcher' mainClassName = "${moduleName}/${moduleMainClass}"
The shaded JAR should not be a modular JAR thus its entry point should only be moduleMainClass.
moduleMainClass
shadowJar { manifest { attributes('Main-Class': moduleMainClass) } }
Should result in the manifest containing an entry as the following one
Main-Class: org.kordamp.ikonli.browser.Launcher
The generated manifest contains the full modularized main class
Main-Class: org.kordamp.ikonli.browser/org.kordamp.ikonli.browser.Launch er
Even if the following is added
shadowJar.doLast { manifest.attributes('Main-Class': moduleMainClass) }
It seems https://github.com/johnrengelman/shadow/blob/master/src/main/groovy/com/github/jengelman/gradle/plugins/shadow/ShadowApplicationPlugin.groovy#L59-L64 always takes effect no matter what.
The text was updated successfully, but these errors were encountered:
mainClass
JavaApplication
Successfully merging a pull request may close this issue.
Shadow Version
6.1.0
Gradle Version
6.3
Expected Behavior
A project with
application
andshadow
plugins applied.The project makes use of Java modules, thus
mainClassName
is set toThe shaded JAR should not be a modular JAR thus its entry point should only be
moduleMainClass
.Should result in the manifest containing an entry as the following one
Actual Behavior
The generated manifest contains the full modularized main class
Even if the following is added
It seems https://github.com/johnrengelman/shadow/blob/master/src/main/groovy/com/github/jengelman/gradle/plugins/shadow/ShadowApplicationPlugin.groovy#L59-L64 always takes effect no matter what.
The text was updated successfully, but these errors were encountered: