Merge pull request #675 from mjulianotq/674

Moved graldeApi() exclusion to the task configuration.
GradleUp · Aug 1, 2021 · 1f86896 · 1f86896
2 parents 63328d7 + 2f94a25
commit 1f86896
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/src/main/groovy/com/github/jengelman/gradle/plugins/shadow/ShadowJavaPlugin.groovy b/src/main/groovy/com/github/jengelman/gradle/plugins/shadow/ShadowJavaPlugin.groovy
@@ -87,6 +87,9 @@ class ShadowJavaPlugin implements Plugin<Project> {
             shadow.configurations = [project.configurations.findByName('runtimeClasspath') ?
                                              project.configurations.runtimeClasspath : project.configurations.runtime]
             shadow.exclude('META-INF/INDEX.LIST', 'META-INF/*.SF', 'META-INF/*.DSA', 'META-INF/*.RSA', 'module-info.class')
+            shadow.dependencies {
+                exclude(dependency(project.dependencies.gradleApi()))
+            }
         }
         project.artifacts.add(ShadowBasePlugin.CONFIGURATION_NAME, project.tasks.named(SHADOW_JAR_TASK_NAME))
         configureShadowUpload()

diff --git a/src/main/groovy/com/github/jengelman/gradle/plugins/shadow/ShadowPlugin.groovy b/src/main/groovy/com/github/jengelman/gradle/plugins/shadow/ShadowPlugin.groovy
@@ -34,15 +34,6 @@ class ShadowPlugin implements Plugin<Project> {
                     }
                 }
             }
-
-            afterEvaluate {
-                plugins.withId('java-gradle-plugin') {
-                    // needed to prevent inclusion of gradle-api into shadow JAR
-                    configurations.named(JavaPlugin.API_CONFIGURATION_NAME) {
-                        dependencies.remove(project.dependencies.gradleApi())
-                    }
-                }
-            }
         }
     }
 }