Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUSTSEC-2021-0145: Potential unaligned read #3084

Closed
github-actions bot opened this issue Apr 5, 2023 · 1 comment · Fixed by #3087
Closed

RUSTSEC-2021-0145: Potential unaligned read #3084

github-actions bot opened this issue Apr 5, 2023 · 1 comment · Fixed by #3087
Assignees

Comments

@github-actions
Copy link

github-actions bot commented Apr 5, 2023

Potential unaligned read

Details
Status unsound
Package atty
Version 0.2.14
URL softprops/atty#50
Date 2021-07-04

On windows, atty dereferences a potentially unaligned pointer.

In practice however, the pointer won't be unaligned unless a custom global allocator is used.

In particular, the System allocator on windows uses HeapAlloc, which guarantees a large enough alignment.

atty is Unmaintained

A Pull Request with a fix has been provided over a year ago but the maintainer seems to be unreachable.

Last release of atty was almost 3 years ago.

Possible Alternative(s)

The below list has not been vetted in any way and may or may not contain alternatives;

  • is-terminal
  • std::io::IsTerminal nightly-only experimental

See advisory page for additional details.

@djmitche djmitche self-assigned this Apr 8, 2023
@djmitche
Copy link
Collaborator

djmitche commented Apr 8, 2023

This is a dependency of clap, which is only used for the sync server, which is not really used yet, but is easy enough to upgrade.

It's also a dependency of cbindgen which is used in the codegen xtask. That's just for development use and not shipped to users. So low-risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant