gmail: replace deprecated oauth2client package with google-auth-oauthlib #743
Conversation
I'd be especially supportive of adding these files if they were accompanied by an additional section in the contributing docs describing how to use them as an alternative method of setting up a development environment. |
tests/test_gmail.py
Outdated
|
|
||
| self.assertEqual(service.get_credentials().to_json(), expected.to_json()) | ||
|
|
||
| def test_get_credentials_expired(self): |
There was a problem hiding this comment.
Could you add some comment(s) explaining how this test works? It isn't obvious why mocking Credentials.refresh to return None would yield the same results as expected.__dict__["expiry"] = datetime.now().
There was a problem hiding this comment.
I'm new to mocking and agree my initial test wasn't very clear, but after sleeping on it I think I have a cleaner/more self explanatory solution for this via 7e4c263. Let me know what you think!
|
@ryneeverett can this be merged? I was planning on opening a separate PR for the |
I do plan to merge this but I usually wait a few weeks to give others the opportunity to review. Reviews from others are rare these days but I like to leave a window in hopes that this will change. There isn't much risk of merge conflicts at the current rate of development. Please do submit the Pipfile additions in a separate PR. |
|
Sounds good, thanks! |
Summary
When following the Gmail setup instructions, I discovered that Google's quick start page relies on
google-auth-oauthlibinstead of the deprecatedoauth2clientpackage, whichbugwarriorcurrently uses. Since my credentials had expired, I also discovered that the newcredentials.jsoncreated by following the quick start guide is also incompatible with the old credential file I was using. While I'm no OAuth expert, I used the Python code on the quick start page to make updates tobugwarrior's Gmail service so we can use the newergoogle-auth-oauthlibpackage. Hopefully this saves someone else some trouble! See oauth2client deprecation for more info.Some other clean up items:
gmailas supported service inREADMEand sort list alphabetically.install_requiresandextras_requirealphabetically insetup.py.extras_requireto use{}instead ofdict(), since the former plays nicer with pipenv, which I use forbugwarriordevelopment. Seeextras_requirein setup.py is not correctly evaluated pypa/pipenv#4309 for the relevantpipenvissue. If there's interest, I can open a separate PR with thePipfileandPipfile.lockI use on my fork.