Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to include closed issues for GitHub #625

Closed
pawamoy opened this issue Dec 5, 2018 · 1 comment
Closed

Add an option to include closed issues for GitHub #625

pawamoy opened this issue Dec 5, 2018 · 1 comment

Comments

@pawamoy
Copy link
Contributor

pawamoy commented Dec 5, 2018

With the new githubclosedon UDA added in #621, I would now like to add an option to the GitHub service to also pull closed issues, not only open ones.

@wookietreiber pointed me to these two lines

https://github.com/ralphbean/bugwarrior/blob/2841f05ae66a0d8f8c91c03ec896cad6b8d2cb0a/bugwarrior/services/github.py#L48

https://github.com/ralphbean/bugwarrior/blob/2841f05ae66a0d8f8c91c03ec896cad6b8d2cb0a/bugwarrior/services/github.py#L59

...where we should add a state=all parameter depending on a github.include_closed_issues configuration option. Maybe they are not the only ones we need to change, I will see that.

Will open a PR soon.

@pawamoy
Copy link
Contributor Author

pawamoy commented Jun 24, 2020

Well, the PR was closed (by me), so, closing this as well. Feel free to reopen 🙂

@pawamoy pawamoy closed this as completed Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants