Add "issue/PR state" and "closing date" UDA to GitHub service

[pawamoy]

Hi, thank you for bugwarrior, it's really great 🙂

I'm facing a problem though. I just started using taskwarrior and bugwarrior, and I want to catch up by downloading all my github issue into taskwarrior.

The thing is, by default, only the open issues/PRs are downloaded. A workaround I found for this is the following:

1. specify the github.query without state:open
2. pull a first time to get all issues/PRs
3. add state:open to github.query to filter out closed issues/PRs
4. pull a second time

But then, all the issues that are closed after the second pull, are closed with the end date set to the current date. I don't want this. I want the actual date when it was closed/merged.

So I figured I could also write a taskwarrior hook to modify the tasks when they are added by bugwarrior, but then I lack some info to properly update them. Here is how I would go:

1. set github.query so you get both open/closed issues
2. write and use a on-add or on-modify taskwarrior hook that will identify bugwarrior tasks, and mark them as completed with the githubupdatedat value as end value

But for this I need a value that tells the issue state! open, closed, or merged for PRs.

Also I think the githubupdatedat reflects the date of the last comment/reference/edit of the issue, not the date when it was closed, so I can't even use that value reliably.

So, in the end, what I'm asking is:

1. to add a githubenddate or githubclosedon (or else) UDA, set to none if is still open
2. to optionally add a githubstate UDA (I won't need it if I already have the githubclosedon date)

What do you think 🙂 ?

[pawamoy]

This was implemented in #621, closing 🙂