Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firebase-auth Trigger an event on _locationChanged > _authHandler when there is no login or logout. #117

Open
MartinGerritsen opened this issue Mar 21, 2016 · 2 comments

Comments

@MartinGerritsen
Copy link

Right now, locally, I have touched the firebase-auth.html on line 178 adding an else to the list.

if (this._queuedLogin) {
    this.login(this._queuedLogin.params, this._queuedLogin.options);
    this._queuedLogin = null;
} else if (!this.statusKnown && this.autoLogin) {
    this.login();
} else {
   this.fire('nonaction');
}

If something like this could be added to the basic firebase-auth that would be great!
I am using it to trigger showing a login icon or a logged icon - without it you first see the login icon and you see it jump to the logged icon.

Thanks!

@ebidel
Copy link
Contributor

ebidel commented Mar 21, 2016

Is this #115?

@MartinGerritsen
Copy link
Author

Close to spot on, thanks! (and sorry for missing it). The only difference is that I would like the event to fire only when no other events fire and not always, to distinguish it as a nonaction and not just a general auth attempt which might also become a correct login.

edit: nevermind, I just realized it's spot on 100%! What is the right move to do now? Close this? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants