Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI settings don't persist between reloads #825

Closed
pbakaus opened this issue Mar 27, 2020 · 10 comments · Fixed by #4601
Closed

UI settings don't persist between reloads #825

pbakaus opened this issue Mar 27, 2020 · 10 comments · Fixed by #4601
Assignees
Labels
P1 High priority, must do soon Type: Bug Something isn't working

Comments

@pbakaus
Copy link
Contributor

pbakaus commented Mar 27, 2020

Bug Description

UI settings such as collapsed panel states should persist across reloads. The following settings need to persist:

  • Panel state (collapsed/open)
  • Layer panel height
  • Selected page (let's attach this as hash to the current URL, like Google Slides)

The following should not persist:

  • Selected tab in design panel
  • Selected tab in element panel

/cc @samitron7


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

QA Instructions

@pbakaus pbakaus added the Type: Bug Something isn't working label Mar 27, 2020
@spacedmonkey
Copy link
Contributor

Related: WordPress/gutenberg#15105

@miina
Copy link
Contributor

miina commented Mar 30, 2020

@pbakaus Should the settings persist when the user closes the story and comes back to it later as well, e.g. the next day? Or would that be just for a specific editing session when reloading and when reopening the story again after closing, it should be in the default state?

@pbakaus
Copy link
Contributor Author

pbakaus commented Mar 30, 2020

imo the settings should persist across sessions, analogous with almost every other design tool. @samitron7 to confirm (or disagree).

@jauyong jauyong removed their assignment Apr 3, 2020
@jauyong jauyong added the P1 High priority, must do soon label Apr 3, 2020
@swissspidy swissspidy mentioned this issue Apr 22, 2020
5 tasks
@o-fernandez o-fernandez added P2 Should do soon and removed P1 High priority, must do soon labels May 6, 2020
@ezxyz
Copy link
Contributor

ezxyz commented May 11, 2020

Should the settings be put in local storage? I'm assuming its across sessions on the same browser (not on different browsers, computers etc).

@swissspidy
Copy link
Collaborator

Yeah that'd be something for localStorage. Depending on the feedback above we could easily switch to sessionStorage if necessary.

Bonus: extensible API that supports both, and potentially even persistent storage (e.g. WordPress user profiles) if we'd ever need that.

@pbakaus
Copy link
Contributor Author

pbakaus commented May 11, 2020

+1. We can start with localStorage (I wouldn't do sessionStorage for now, as I predict users might want some level of persistence per browser).

@samitron7
Copy link

Completely agree to paul's recommendation:

"imo the settings should persist across sessions, analogous with almost every other design tool. @samitron7 to confirm (or disagree)."

@o-fernandez o-fernandez added P1 High priority, must do soon and removed P2 Should do soon labels Sep 21, 2020
@o-fernandez o-fernandez added this to the Sprint 38 milestone Sep 21, 2020
@maxyinger maxyinger self-assigned this Sep 21, 2020
@maxyinger
Copy link
Contributor

Persists Following:

  • Panel state (collapsed/open)
  • Layer panel height

#4601

@maxyinger
Copy link
Contributor

maxyinger commented Sep 21, 2020

Persisting active page moved to separate ticket & detailed here:
#4605

@csossi
Copy link

csossi commented Sep 22, 2020

Verified in QA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority, must do soon Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.