-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI settings don't persist between reloads #825
Comments
Related: WordPress/gutenberg#15105 |
@pbakaus Should the settings persist when the user closes the story and comes back to it later as well, e.g. the next day? Or would that be just for a specific editing session when reloading and when reopening the story again after closing, it should be in the default state? |
imo the settings should persist across sessions, analogous with almost every other design tool. @samitron7 to confirm (or disagree). |
Should the settings be put in local storage? I'm assuming its across sessions on the same browser (not on different browsers, computers etc). |
Yeah that'd be something for localStorage. Depending on the feedback above we could easily switch to sessionStorage if necessary. Bonus: extensible API that supports both, and potentially even persistent storage (e.g. WordPress user profiles) if we'd ever need that. |
+1. We can start with localStorage (I wouldn't do sessionStorage for now, as I predict users might want some level of persistence per browser). |
Completely agree to paul's recommendation: "imo the settings should persist across sessions, analogous with almost every other design tool. @samitron7 to confirm (or disagree)." |
Persists Following:
|
Persisting active page moved to separate ticket & detailed here: |
Verified in QA |
Bug Description
UI settings such as collapsed panel states should persist across reloads. The following settings need to persist:
The following should not persist:
/cc @samitron7
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria
QA Instructions
The text was updated successfully, but these errors were encountered: