Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard Settings: Publisher Logos #3483

Closed
7 tasks done
BrittanyIRL opened this issue Jul 27, 2020 · 1 comment
Closed
7 tasks done

Dashboard Settings: Publisher Logos #3483

BrittanyIRL opened this issue Jul 27, 2020 · 1 comment
Assignees
Labels
Group: Dashboard Type: Enhancement New feature or improvement of an existing feature

Comments

@BrittanyIRL
Copy link
Contributor

BrittanyIRL commented Jul 27, 2020

Feature Description

The overarching work for this can be found here for context: #2747

Set up functionality in dashboard settings to read and update publisher logos from wordPress settings API

We will iterate from this on what the UI should look like for active logos, deleting logos, and updating the active logo.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

(all of this is behind a feature flag)

  • Ability to read existing logos from API and render previews
  • Active logo should come first in list
  • If user has permissions ability to update logos ability to update logos (add and delete)
  • If user does not have permissions to update logos this should be disabled
  • Connect error handling to toaster
  • Unit Tests
  • Karma Tests

Implementation Brief

  • UI is already drafted behind feature flag, just need to add in functionality and state changes for permissions
@BrittanyIRL BrittanyIRL added Type: Enhancement New feature or improvement of an existing feature Group: Dashboard Pod: Pea (Dashboard & Templates) labels Jul 27, 2020
@BrittanyIRL BrittanyIRL added this to the Sprint 34 milestone Jul 27, 2020
@BrittanyIRL BrittanyIRL self-assigned this Jul 27, 2020
@bmattb bmattb removed this from the Sprint 34 milestone Jul 27, 2020
@bmattb bmattb added this to the Sprint 35 milestone Aug 10, 2020
@BrittanyIRL
Copy link
Contributor Author

Moving this to done. Feature work is complete and there's a separate ticket to enable feature flag after QA and UAT: #4132

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Group: Dashboard Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants