Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analytics: Print default analytics code if tracking ID is set #3131

Closed
swissspidy opened this issue Jul 10, 2020 · 1 comment · Fixed by #3549
Closed

Analytics: Print default analytics code if tracking ID is set #3131

swissspidy opened this issue Jul 10, 2020 · 1 comment · Fixed by #3549
Labels
Group: WordPress Changes related to WordPress or Gutenberg integration Type: Enhancement New feature or improvement of an existing feature

Comments

@swissspidy
Copy link
Collaborator

swissspidy commented Jul 10, 2020 •
edited
Loading

Feature Description

Depends on #3031 / #2747.

Related but not a blocker: #2731

We need to print a default <amp-analytics> code for Google Analytics if a tracking ID is set and

Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance Criteria

Implementation Brief

  • In \Google\Web_Stories\Analytics print own analytics code if tracking ID is set
  • Verify \Google\Web_Stories\Analytics::is_site_kit_analytics_module_active functionality - if Site Kit's analytics module is active, don't print anything
@swissspidy swissspidy added Type: Enhancement New feature or improvement of an existing feature Group: WordPress Changes related to WordPress or Gutenberg integration Pod: WP & Infra labels Jul 10, 2020
@swissspidy swissspidy mentioned this issue Jul 10, 2020
Closed
@swissspidy swissspidy mentioned this issue Jul 24, 2020
Merged
@bmattb bmattb added this to the Sprint 34 milestone Jul 27, 2020
@swissspidy
Copy link
Collaborator Author

Note that most of this was already handled by #3437

Now we just need to ensure the Site Kit check is correct, and then do some quick testing.

@swissspidy swissspidy mentioned this issue Jul 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Group: WordPress Changes related to WordPress or Gutenberg integration Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve Site Kit Analytics module detection GoogleForCreators/web-stories-wp
2 participants
@swissspidy @bmattb