-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Settings Data: Publisher Logos #3032
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi @BrittanyIRL, A quick update on this issue: We decided to keep things RESTful and DRY and use existing functionality as much as possible. There's a robust Usage for both depends on whether the user is allowed to upload files or manage settings in WordPress. We pass that info via There's a maximum upload limit (file size), check The media upload is heavily used in the editor already, so it's easiest to just check that for reference on how upload works. Examples: Change active/default publisher logo: await wp.apiFetch({ path: 'wp/v2/settings', method: 'POST', data: {
web_stories_active_publisher_logo: 123
} }); Update list of all publisher logos: await wp.apiFetch({ path: 'wp/v2/settings', method: 'POST', data: {
web_stories_publisher_logos: [123, 456],
} }); Upload a new image
Get all publisher logos including their sources: 1 Remove publisher logo
|
@swissspidy this all is great with me, thanks for the details on implementation! |
Feature Description
See this ticket for more context of page:#2747
We need to be able to set and remove publisher logos from the dashboard
Alternatives Considered
Additional Context
Do not alter or remove anything below. The following sections will be managed by moderators only.
Acceptance Criteria
On upload should check that image fits specs (Whether the image is a perfect square, Whether it is at least 96 x 96px large) and if not return an error for it.Implementation Brief
The text was updated successfully, but these errors were encountered: