Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rollup config for SVGs #10914

Closed
swissspidy opened this issue Mar 14, 2022 · 0 comments · Fixed by #10915
Closed

Update Rollup config for SVGs #10914

swissspidy opened this issue Mar 14, 2022 · 0 comments · Fixed by #10915
Assignees
@swissspidy
Labels
Type: Infrastructure Changes impacting testing infrastructure or build tooling

Comments

@swissspidy
Copy link
Collaborator

Task Description

Since #5792 the webpack and Rollup config got out of sync. We need to ensure this works in Rollup builds:

  • SVGs in icons folder should be components
  • SVGs in images folder should be components but with different config
  • SVGs in inline-images should be imported as base64 inlined URls
@swissspidy swissspidy added Type: Infrastructure Changes impacting testing infrastructure or build tooling Pod: WP labels Mar 14, 2022
@swissspidy swissspidy self-assigned this Mar 14, 2022
@swissspidy swissspidy mentioned this issue Mar 14, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swissspidy swissspidy

Labels
Type: Infrastructure Changes impacting testing infrastructure or build tooling
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Rollup config GoogleForCreators/web-stories-wp
1 participant
@swissspidy