Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the logs muted if an error occurred #926

Closed
wants to merge 1 commit into from

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Aug 23, 2018

Fixes #923

Signed-off-by: David Gageot [email protected]

@dgageot dgageot added the wip label Aug 23, 2018
@dgageot dgageot requested review from balopat and r2d4 as code owners August 23, 2018 12:15
@codecov-io
Copy link

codecov-io commented Aug 23, 2018

Codecov Report

Merging #926 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #926      +/-   ##
==========================================
+ Coverage   41.71%   41.73%   +0.02%     
==========================================
  Files          61       61              
  Lines        2522     2523       +1     
==========================================
+ Hits         1052     1053       +1     
  Misses       1356     1356              
  Partials      114      114
Impacted Files Coverage Δ
pkg/skaffold/runner/runner.go 54.85% <100%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80a04db...924a78f. Read the comment docs.

@dgageot dgageot closed this Aug 23, 2018
@dgageot dgageot deleted the fix-923 branch December 28, 2018 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants